feat(msgs): vendor 11 standard ROS 2 packages for Jazzy coverage#215
Merged
Conversation
2 tasks
YuanYuYuan
force-pushed
the
feat/msgs-jazzy-coverage
branch
2 times, most recently
from
412148b to
6552b40
Compare
Contributor
|
Looks good. Thank you. |
- Parse all new packages (tf2_msgs, visualization_msgs, rosgraph_msgs, trajectory_msgs, diagnostic_msgs, shape_msgs, stereo_msgs, statistics_msgs, composition_interfaces, std_srvs, rosbag2_interfaces) - Verify LookupTransform.action empty Feedback parses as zero-field message - Resolve in both Humble and Jazzy resolver modes - Check all new types produce well-formed RIHS01_ hashes Also fix missing trailing newline in dependencies.json.
test_msgs::BasicTypes has a wstring field that is skipped by codegen, but Nested* types referencing it still get generated, causing E0412 when all_msgs is enabled. test_msgs is an internal ROS 2 test package and does not belong in a production all_msgs umbrella.
Add comment explaining why test_msgs is excluded from all_msgs (wstring field causes codegen to skip BasicTypes, but Nested* still references it). Replace unwrap_or_default() + skip-if-empty pattern in the action hash test with unwrap_or_else(panic!) — result/feedback are always Some after the parser fix, so silent skipping would mask regressions.
YuanYuYuan
force-pushed
the
feat/msgs-jazzy-coverage
branch
from
0ef6220 to
dd8c969
Compare
Collaborator
Author
|
The CI is finally green. Thanks again @vihaan-kovari! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common_interfaces,rcl_interfaces,geometry2, androsbag2to 100% Jazzy coverage)hiroz-codegenaction parser to treat emptyResult/Feedbacksections as zero-field messages (required fortf2_msgs/LookupTransform.action)hiroz-codegenintegration tests covering all 11 new packages (parse, resolve Jazzy/Humble, type hash sanity)--features all_msgscheck tocheck-bundled-msgsCIPackages added
From
ros2/common_interfaces:diagnostic_msgs,shape_msgs,stereo_msgs,trajectory_msgs,visualization_msgs,std_srvsFrom
ros2/rcl_interfaces:rosgraph_msgs,statistics_msgs,composition_interfacesFrom
ros2/geometry2:tf2_msgs(msg + srv + action)From
ros/rosbag2:rosbag2_interfacesDependencies
tf2_msgshere is a superset; feat(tf): add hiroz-tf crate with TF2 listener, broadcaster, and buffer #191 should drop itstf2_msgsassets after this mergesfix/python-stub-ordering) should merge first to clean up the non-deterministic Python stub reordering noise visible in this diffBreaking Changes
None