Skip to content

feat(msgs): vendor 11 standard ROS 2 packages for Jazzy coverage#195

Closed
vihaan-kovari wants to merge 3 commits into
ZettaScaleLabs:mainfrom
Kovari-Industries:feat/expand-msg-coverage
Closed

feat(msgs): vendor 11 standard ROS 2 packages for Jazzy coverage#195
vihaan-kovari wants to merge 3 commits into
ZettaScaleLabs:mainfrom
Kovari-Industries:feat/expand-msg-coverage

Conversation

@vihaan-kovari

@vihaan-kovari vihaan-kovari commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

  • Vendor 11 additional standard ROS 2 message packages
  • Fix hiroz-codegen action parser to handle empty Result/Feedback sections (matching ROS 2 / rosidl semantics). Example of this is tf2_msgs/LookupTransform.action, which has an empty feedback section.

The messages added are:

  • From ros2/common_interfaces: diagnostic_msgs, shape_msgs, stereo_msgs, trajectory_msgs, visualization_msgs, std_srvs
  • From ros2/rcl_interfaces: rosgraph_msgs, statistics_msgs, composition_interfaces
  • From ros2/geometry2: tf2_msgs
  • From ros/rosbag2: rosbag2_interfaces

Vendors every remaining interface package from ros2/common_interfaces, ros2/rcl_interfaces, ros2/geometry2, and ros2/rosbag2, bringing Jazzy coverage of these four repos to 100%.

This PR overlaps with #191 on tf2_msgs vendoring, but adds all tf2_msgs.

Checklist

  • Ran ./scripts/check-local.sh successfully
  • Added/updated tests/documentation (if applicable)

External contributors: Please open as draft initially. See CONTRIBUTING.md.

@CLAassistant

CLAassistant commented Jun 2, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vihaan-kovari vihaan-kovari changed the title Feat/expand msg coverage feat(msgs): vendor 11 standard ROS 2 packages for Jazzy coverage Jun 2, 2026
@vihaan-kovari vihaan-kovari marked this pull request as ready for review June 2, 2026 04:37
@vihaan-kovari

Copy link
Copy Markdown
Contributor Author

@YuanYuYuan Please let me know your thoughts on this.

@YuanYuYuan

YuanYuYuan commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the contribution @vihaan-kovari! The work here is solid.

We couldn't push fixes directly to your branch since maintainer edits were disabled, so we've opened #215 which preserves your commits (with original authorship) and adds a few fixups on top:

  • Trailing newline in dependencies.json
  • Codegen coverage tests for the 11 new packages (Humble + Jazzy resolver modes, type hash validation, LookupTransform empty-Feedback assertion)
  • Exclude test_msgs from all_msgs (its BasicTypes type is skipped due to a wstring field, which breaks types that depend on it)
  • Add --features all_msgs check to CI

The remaining CI failures on this PR are infrastructure issues affecting all external contributor PRs — not caused by your code:

Both are fixed in the CI patch already merged to main, which is another reason we moved to a fresh branch.

Closing in favour of #215.

@YuanYuYuan YuanYuYuan closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants