Skip to content

webp-uploads: Link to FAQ from Modern Image Formats settings section #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gilmoursa wants to merge 1 commit into from
Closed

webp-uploads: Link to FAQ from Modern Image Formats settings section #2483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion plugins/webp-uploads/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,25 @@ function webp_uploads_register_media_settings_field(): void {
}
add_action( 'init', 'webp_uploads_register_media_settings_field' );

/**
* Renders the description for the Modern Image Formats settings section.
*
* @since n.e.x.t
*/
function webp_uploads_modern_image_formats_section_callback(): void {
printf(
'<p class="description">%s</p>',
wp_kses(
sprintf(
/* translators: %s: URL to the plugin FAQ. */
__( 'If converted images are not appearing as expected after upload, refer to the <a href="%s">FAQ</a> for common reasons why.', 'webp-uploads' ),
'https://wordpress.org/plugins/webp-uploads/#faq'
),
array( 'a' => array( 'href' => array() ) )
)
);
}

/**
* Adds media settings field for the 'perflab_generate_webp_and_jpeg' setting.
*
Expand All @@ -79,7 +98,7 @@ function webp_uploads_add_media_settings_fields(): void {
add_settings_section(
'perflab_modern_image_format_settings',
_x( 'Modern Image Formats', 'settings page section name', 'webp-uploads' ),
'__return_empty_string',
'webp_uploads_modern_image_formats_section_callback',
'media',
array(
'before_section' => '<div id="modern-image-formats">',
Expand Down
12 changes: 12 additions & 0 deletions plugins/webp-uploads/tests/test-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,18 @@

class Test_WebP_Uploads_Settings extends WP_UnitTestCase {

/**
* @covers ::webp_uploads_modern_image_formats_section_callback
*/
public function test_webp_uploads_modern_image_formats_section_callback(): void {
ob_start();
webp_uploads_modern_image_formats_section_callback();
$output = ob_get_clean();

$this->assertStringContainsString( 'https://wordpress.org/plugins/webp-uploads/#faq', $output );
$this->assertStringContainsString( '<p class="description">', $output );
}

/**
* @covers ::webp_uploads_add_settings_action_link
*/
Expand Down
Loading