webp-uploads: Link to FAQ from Modern Image Formats settings section#2483
webp-uploads: Link to FAQ from Modern Image Formats settings section#2483Gilmoursa wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Adds a description paragraph to the Modern Image Formats settings section that links to the plugin FAQ on WordPress.org, so users can understand why converted images may not appear after upload without leaving the admin dashboard. Fixes WordPress#2442
6d3fec0 to
89c151e
Compare
|
Hummm. You already opened a PR for this: #2480 Please use that existing pull request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2483 +/- ##
==========================================
+ Coverage 69.33% 69.37% +0.03%
==========================================
Files 90 90
Lines 7749 7758 +9
==========================================
+ Hits 5373 5382 +9
Misses 2376 2376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
My apologies — I didn't realize #2480 was already open for this! Closing this one in favor of that. Thanks for catching it 🙏 |
Summary
Fixes #2442.
Adds a description paragraph to the Modern Image Formats settings section that links to the FAQ on WordPress.org, so users can find an explanation for why converted images may not appear after upload without leaving the admin dashboard.
Relevant technical choices
The FAQ in
readme.txtalready covers the two main reasons images aren't converted (converted file is larger than the original; image was not uploaded via the Media Library). Rather than duplicating that text, this links to it from the settings section.__return_empty_stringfor the section callback is replaced with a namedwebp_uploads_modern_image_formats_section_callback()function (following the pattern used inspeculation-rules/settings.php). A unit test is added to assert the output contains the FAQ URL and wrapper element.Use of AI Tools
This PR was authored with Claude Code (Anthropic). Claude wrote the code and opened the PR. I reviewed the diff, the issue discussion, the PR template, and the CONTRIBUTING.md requirements before approving.