Skip to content

webp-uploads: Link to FAQ from Modern Image Formats settings section#2483

Closed
Gilmoursa wants to merge 1 commit into
WordPress:trunkfrom
Gilmoursa:add-modern-image-formats-faq-link
Closed

webp-uploads: Link to FAQ from Modern Image Formats settings section#2483
Gilmoursa wants to merge 1 commit into
WordPress:trunkfrom
Gilmoursa:add-modern-image-formats-faq-link

Conversation

@Gilmoursa

@Gilmoursa Gilmoursa commented May 15, 2026

Copy link
Copy Markdown

Summary

Fixes #2442.

Adds a description paragraph to the Modern Image Formats settings section that links to the FAQ on WordPress.org, so users can find an explanation for why converted images may not appear after upload without leaving the admin dashboard.

Relevant technical choices

The FAQ in readme.txt already covers the two main reasons images aren't converted (converted file is larger than the original; image was not uploaded via the Media Library). Rather than duplicating that text, this links to it from the settings section.

__return_empty_string for the section callback is replaced with a named webp_uploads_modern_image_formats_section_callback() function (following the pattern used in speculation-rules/settings.php). A unit test is added to assert the output contains the FAQ URL and wrapper element.

Use of AI Tools

This PR was authored with Claude Code (Anthropic). Claude wrote the code and opened the PR. I reviewed the diff, the issue discussion, the PR template, and the CONTRIBUTING.md requirements before approving.

@github-actions

github-actions Bot commented May 15, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Gilmoursa <gilmoursa@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: b1ink0 <b1ink0@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Adds a description paragraph to the Modern Image Formats settings
section that links to the plugin FAQ on WordPress.org, so users can
understand why converted images may not appear after upload without
leaving the admin dashboard.

Fixes WordPress#2442
@Gilmoursa Gilmoursa force-pushed the add-modern-image-formats-faq-link branch from 6d3fec0 to 89c151e Compare May 15, 2026 21:29
@westonruter

Copy link
Copy Markdown
Member

Hummm. You already opened a PR for this: #2480

Please use that existing pull request.

@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.37%. Comparing base (347597f) to head (89c151e).
⚠️ Report is 5 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/webp-uploads/settings.php 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #2483      +/-   ##
==========================================
+ Coverage   69.33%   69.37%   +0.03%     
==========================================
  Files          90       90              
  Lines        7749     7758       +9     
==========================================
+ Hits         5373     5382       +9     
  Misses       2376     2376              
Flag Coverage Δ
multisite 69.37% <90.00%> (+0.03%) ⬆️
single 35.80% <90.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gilmoursa

Copy link
Copy Markdown
Author

My apologies — I didn't realize #2480 was already open for this! Closing this one in favor of that. Thanks for catching it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add explanation for why modern format images may not appear after upload

2 participants