Skip to content

Editor: Conditionally enable the new default rendering mode for Pages#69160

Merged
Mamaduka merged 2 commits into
trunkfrom
update/pages-editor-default-rendering-mode
Feb 13, 2025
Merged

Editor: Conditionally enable the new default rendering mode for Pages#69160
Mamaduka merged 2 commits into
trunkfrom
update/pages-editor-default-rendering-mode

Conversation

@Mamaduka

@Mamaduka Mamaduka commented Feb 12, 2025

Copy link
Copy Markdown
Member

What?

Part of #68684.

PR updates logic to enable a new default mode for pages and only enables it for block-based themes.

Why?

See: WordPress/wordpress-develop#8123 (comment)

Testing Instructions

Using a block theme.

  1. Open a page.
  2. Confirm that it loads with a template-locked view.
  3. Doesn't change the current behavior.

Using a hybrid theme.

  1. Open a page.
  2. Create a block-based template for it and save it.
  3. Confirm that it doesn't load with a template-locked view

Testing Instructions for Keyboard

Same.

Screenshots or screencast

Screenshot 2025-02-12 at 18 02 37

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Package] Editor /packages/editor [Feature] Template Editing Mode Related to the template editor available in the Block Editor labels Feb 12, 2025
@Mamaduka Mamaduka self-assigned this Feb 12, 2025
@Mamaduka Mamaduka marked this pull request as ready for review February 12, 2025 10:14
@github-actions

github-actions Bot commented Feb 12, 2025

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right compromise for 6.8 and we should ship this in the Betas with a Call for testing 👍 :)

@audrasjb audrasjb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code logic here looks good to me 👍

@Mamaduka

Copy link
Copy Markdown
Member Author

Thanks everyone for the feedback 🙇

@Mamaduka Mamaduka merged commit e9bb574 into trunk Feb 13, 2025
@Mamaduka Mamaduka deleted the update/pages-editor-default-rendering-mode branch February 13, 2025 01:51
@github-actions github-actions Bot added this to the Gutenberg 20.4 milestone Feb 13, 2025
Kallyan01 pushed a commit to Kallyan01/gutenberg that referenced this pull request Feb 24, 2025
…WordPress#69160)


Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
chriszarate pushed a commit to chriszarate/gutenberg that referenced this pull request Jul 1, 2025
…WordPress#69160)


Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Template Editing Mode Related to the template editor available in the Block Editor [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants