Editor: Add an extra check before enabling the new default rendering mode for Pages#69209
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
left a comment
There was a problem hiding this comment.
Looks good to me 👍
though really I would expect that then support to be a check that happens inside the is_block_theme function because what is a blink theme if not block templates?
|
@fabiankaegy, I think the current behavior is for legacy reasons. WP shipped The |
…mode for Pages (WordPress#69209) * Editor: Add an extra check before enabling the new default rendering mode for Pages * Add backport changelog entry Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
…mode for Pages (WordPress#69209) * Editor: Add an extra check before enabling the new default rendering mode for Pages * Add backport changelog entry Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
What?
This is a small follow-up to #69160.
PR hardens condition before enabling
template-lockedas default rendering mode for Pages.Why?
While it should be an edge case for a block theme not to support
block-templates, it's still technically doable. See: #67875 (comment).Testing Instructions
block-templatestheme support.post-onlymode.Testing Instructions for Keyboard
Same.