Edit site: Do not autoformat edit-site/lib#62573
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
changed the title
Member
Author
|
Related: #53653 |
|
Size Change: 0 B Total Size: 1.76 MB ℹ️ View Unchanged
|
sirreal
force-pushed
the
remove/unbrotli-autoformatting
branch
from
0799898 to
403b1dc
Compare
|
Flaky tests detected in 403b1dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9516619862
|
sirreal
force-pushed
the
remove/unbrotli-autoformatting
branch
from
f07b7fd to
a223b55
Compare
youknowriad
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Disable and revert autoformatting for
edit-site/libvendored files. These appear to be compiled external files that should not be auto-formatted.Why?
In #62572 I noticed some suspicious files being autoformatted so investigated. It seems that these files were autoformatted in #54458 (see this comment) so I reverted that autoformatting as well. According to git, that was the last change to the
edit-site/libdirectory so I restored the directory to it's state prior to that commit withgit checkout b06240a7ce93caf3d1c410267634b3d3d6d5a514~ -- packages/edit-site/lib.This also adds a git attribute to indicate that the directory contains vendored code. This should improve GitHub statistics for the project.
Testing Instructions
npm run formatdoes not format anything inpackages/edit-site/lib(on trunk it would).