Mobile Release v1.104.0#54458
Merged
Merged
Conversation
fluiddot
added
the
Mobile App - i.e. Android or iOS
4 tasks
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
dcalhoun
approved these changes
Sep 14, 2023
# Conflicts: # package-lock.json # packages/react-native-aztec/package.json # packages/react-native-bridge/package.json # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
fluiddot
commented
Sep 15, 2023
Contributor
Author
There was a problem hiding this comment.
This file as well as packages/edit-site/lib/unbrotli.js, platform-docs/docs/basic-concepts/_category_.json, and platform-docs/package-lock.json were automatically modified when updating this PR with trunk. The pre-commit Git hook executed the command npx lint-staged and it identified that those files needed code formatting.
Seems that this PR introduced the first two files (packages/edit-site/lib/lib-font.browser.js and packages/edit-site/lib/unbrotli.js), so I'd like to ping the author @matiasbenedetto for a confirmation that the changes are safe to merge into trunk.
Regarding the last two (platform-docs/docs/basic-concepts/_category_.json and platform-docs/package-lock.json), the formatting change seems legit. Nevertheless, I also would like to ping the author @youknowriad of the PR where it was introduced for a double-check.
Thanks for the help 🙇 !
Contributor
There was a problem hiding this comment.
Platform-docs changes are all good for me thanks :)
Contributor
There was a problem hiding this comment.
👋 Yes, packages/edit-site/lib/lib-font.browser.js and packages/edit-site/lib/unbrotli.js are safe to merge. These files are part of the lib-font package. Soon, the way of bundling them will change but for now they are OK.
Contributor
Author
There was a problem hiding this comment.
Great, thank you both Riad and Matias for the feedback 🙇 . I'll proceed with merging the PR then.
Member
There was a problem hiding this comment.
I came across these files being autoformatted again. Let's revert the formatting changes introduced here and exclude this directory from autoformatting. From what I understand these aren't files that are authored in Gutenberg: #62573
|
Flaky tests detected in f3a2d8c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6196592668
|
# Conflicts: # packages/react-native-editor/ios/Podfile.lock
sirreal
added a commit
that referenced
this pull request
Jun 14, 2024
sirreal
added a commit
that referenced
this pull request
Jun 14, 2024
sirreal
added a commit
that referenced
this pull request
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release 1.104.0 of the react-native-editor and Gutenberg-Mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#6204