Home Link: Render Home text if there is no attribute label present#58387
Merged
Conversation
tjcafferkey
added
[Type] Enhancement
|
Size Change: +10 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ockham
reviewed
Jan 29, 2024
ockham
reviewed
Jan 30, 2024
Co-authored-by: Bernie Reiter <96308+ockham@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58307
What?
Renders default label as "Home" rather than using
useEffectto set the attribute in the Editor client side unless user explicitly sets it on the block themselves and saves it.Why?
Using the Block Hooks API it's now possible to insert this block into the Navigation without default attributes since #57754.
As it stands, without a default
labelattribute this block won't render on the frontend.How?
This renders a default label as
Homeunless a user has set this attribute, in which case it will override the default. We are unable to set the default inblock.jsonsince it won't be translated.Testing Instructions
block.jsonfile of the Home Link block.Testing Instructions for Keyboard
Screenshots or screencast