Home Link: Remove label attribute synchronization#67151
Merged
Conversation
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -29 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e090dba. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11930058707
|
t-hamano
approved these changes
Nov 20, 2024
t-hamano
left a comment
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I have confirmed that it works correctly in languages other than English.
Member
Author
|
Thank you, @t-hamano! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #58387.
PR removes client-side
labelattribute synchronization for the Home Link block in favor of render time default.Why?
The PHP side defaults shouldn't be preferred over the client-side synchronization for translatable strings when possible.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast