Use consistent labels, remove additional settings, and copySmall icon LinkControl#58183
Merged
Conversation
richtabor
added
[Type] Enhancement
|
Size Change: +242 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4aa7bef1dfd0a401ccdf3f5ac0793bafeb295c60. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7813665579
|
richtabor
changed the title
jeryj
force-pushed
the
tweak/linkcontrol-preview
branch
from
9ff38a3 to
8699361
Compare
Member
Author
|
For reference, here's with the latest LinkControl changes + this PR: link.mp4Compared to current WordPress 6.4: link-old.mp4 |
getdave
requested changes
Jan 26, 2024
getdave
left a comment
getdave
left a comment
Contributor
There was a problem hiding this comment.
Visually I like this. It's cleaner and neater.
I left a few comments with a few concerns which I think we should address before this is merged.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
force-pushed
the
tweak/linkcontrol-preview
branch
from
09445ca to
56c1c39
Compare
getdave
approved these changes
Feb 7, 2024
getdave
left a comment
getdave
left a comment
Contributor
There was a problem hiding this comment.
Thank you to @jeryj and @richtabor for resolving my concerns:
- breaking removal of
Opens in new tabcheckbox into a seperate PR - ensuring we still have a means to view the full URL (now via Copy button)
LGTM 🚀
getdave
force-pushed
the
tweak/linkcontrol-preview
branch
from
4aa7bef to
cf112d7
Compare
scruffian
force-pushed
the
tweak/linkcontrol-preview
branch
from
cf112d7 to
e91e505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the "Open in new tab" control from the preview, originally applied in #53566 as a stop-gap (now that #57726 has landed, and #50892 is on the way.)
Also:
How?
Testing Instructions
Screenshots or screencast