Link Control: Simplify the sprintf#58831
Merged
Merged
Conversation
scruffian
added
the
[Feature] Link Editing
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Feb 8, 2024
Contributor
|
PHP failures are unrelated to this PR. As I believe are React Native failures. |
scruffian
force-pushed
the
simplify/link-control-sprintf
branch
from
19d186c to
fcf4e17
Compare
|
Flaky tests detected in 6f118a4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7832664726
|
scruffian
force-pushed
the
simplify/link-control-sprintf
branch
from
fcf4e17 to
6f118a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Simplify this sprintf. We introduced this in #58183 but I don't think we need two parameters.
Why?
Cleaner, simpler code.
How?
Combine the URL and the colon into one variable.
Testing Instructions
Screenshots or screencast