DataViews: add front page to pages page sidebar#57759
Merged
Merged
Conversation
|
Size Change: +39 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Member
Author
|
Copying my comment from the original conversation: #57690 (comment)
Essentially, I think we should go with this PR. |
oandregal
requested review from
jameskoster,
jorgefilipecosta,
ntsekouras and
youknowriad
oandregal
added
[Type] Experimental
jameskoster
approved these changes
Jan 11, 2024
jameskoster
left a comment
jameskoster
left a comment
Contributor
There was a problem hiding this comment.
This seems to be working well. Front Page is included when the homepage is set to display latest posts. This falls back to Blog Home if Front Page isn't found.
Member
Author
Ok, let's go with this one and put #57758 in the back burner for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
Follow-up to #57578 and #57690
Alternative to #57758
What?
Adds the
Front Pageto the sidebar of the Pages page, together with404andSearch.Why?
The existing pages page has a few things other than the pages: the
404&Searchtemplates, as well as the template for theFront Page. This has been done probably for findability: let users know that these are "pages" even if they don't create them.We need to figure out where or whether they still make sense in a dataviews-powered page.
An alternative approach is to show them as part of the list of pages. #57758 is a proof of concept to explore that instead.
How?
Adds the
Front pageto the sidebar.Testing Instructions