DataViews: proof of concept to list pages and key templates in the same list#57758
Closed
oandregal wants to merge 1 commit into
Closed
DataViews: proof of concept to list pages and key templates in the same list#57758oandregal wants to merge 1 commit into
oandregal wants to merge 1 commit into
Conversation
|
Size Change: +121 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Member
Author
|
Copying my comment from the original conversation: #57690 (comment)
Essentially, I think this PR is not worth pursuing at this stage. |
oandregal
requested review from
jameskoster,
jorgefilipecosta,
ntsekouras and
youknowriad
oandregal
added
[Type] Experimental
Member
Author
|
We'll go ahead with #57759 (review) instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
Follow-up to #57578 and #57690
Alternative to #57759
What?
This is a proof of concept that explores adding the
Front Pageto the list of pages.Gravacao.do.ecra.2024-01-11.as.13.10.04.mov
Why?
The existing pages page has a few things other than the pages: the
404&Searchtemplates, as well as the template for theFront Page. This has been done probably for findability: let users know that these are "pages" even if they don't create them.We need to figure out where or whether they still make sense in a dataviews-powered page.
An alternative approach to this one is to maintain the sidebar, and have the templates there. #57759 explores this.
How?
TBD.
Testing Instructions
Things that work:
Things that do not work (or don't properly):