Block bindings: Add support for creating bindings in templates#57315
Closed
SantosGuillamot wants to merge 20 commits into
Closed
Block bindings: Add support for creating bindings in templates#57315SantosGuillamot wants to merge 20 commits into
SantosGuillamot wants to merge 20 commits into
Conversation
SantosGuillamot
added
the
[Feature] Block API
SantosGuillamot
added
the
[Type] New API
|
Size Change: +262 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
SantosGuillamot
added
[Feature] Custom Fields
This was referenced Dec 22, 2023
Contributor
Author
|
I believe that these are the remaining issues for this part of the prototype.
|
michalczaplinski
force-pushed
the
add/block-bindings-api-editor-ui-and-apis
branch
4 times, most recently
from
11ba9d7 to
934715b
Compare
Contributor
Author
|
Closing this because the block bindings API implementation has changed, and it should follow a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is built on top of #57258
What?
I'm adding the possibility of creating bindings in the templates. As part of that, I'm modifying the "Post meta" source to ensure it works there and to show only the relevant meta for that template:
There are still some aspects to review, especially regarding the UX.
I've recorded this video to showcase how it works for the movies template:
Templating.demo.mp4
Why?
With the current implementation the UI in the editor to connect post meta, doesn't work in templates because it requires a specific ID, which is not available in the template.
How?
Testing Instructions
To do so, you can add a paragraph, click the bindings button, and select the "content" attribute, for example.
This is the list of different templates I identified:
4 . Go to the frontend and check it gets the context correctly.
Remaining issues