Block Bindings API: Add taxonomy meta source in templates#57343
Closed
SantosGuillamot wants to merge 4 commits into
Closed
Block Bindings API: Add taxonomy meta source in templates#57343SantosGuillamot wants to merge 4 commits into
SantosGuillamot wants to merge 4 commits into
Conversation
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/block-bindings/sources/tax-meta.php ❔ lib/experimental/block-bindings/index.php |
|
Size Change: +290 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
SantosGuillamot
added
[Type] Feature
SantosGuillamot
changed the title
42 tasks
Contributor
Author
|
Closing this because the block bindings API implementation has changed, and it should follow a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is built on top of #57315
What?
In this pull request, I'm adding a new core source to the block bindings API for the taxonomy source. This source only appears in the templates related to a taxonomy, and it retrieves the available fields for each of them. In the server, it uses the
get_metadatafunction to get the value.I'm implementing the same logic used for Post meta here, but adapted for the taxonomy. Please check that PR for more info about it.
Why?
Sometimes, users will want to consume meta fields related to a taxonomy and not only to a page/post.
How?
I'm creating a new source for the block bindings:
get_metadatafunction to retrieve the value.Testing Instructions