Site editor: use constants rather than hard coded template strings#54586
Merged
Conversation
|
Size Change: +24 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ramonjd
added
[Type] Code Quality
ramonjd
force-pushed
the
update/edit-site-constants-part-2
branch
from
fdea1c8 to
e79b67c
Compare
ramonjd
requested review from
andrewserong,
apeatling,
glendaviesnz,
kevin940726 and
tellthemachines
ramonjd
force-pushed
the
update/edit-site-constants-part-2
branch
2 times, most recently
from
5831500 to
a2b821f
Compare
andrewserong
approved these changes
Sep 21, 2023
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Nice follow-up!
This PR includes an empty file for packages/edit-site/src/components/block-editor/get-block-editor-provider.js — looks like as a result of a rebase? I think that onej ust needs to be removed.
The code changes all look good and match to the right constants. Gave the following areas a smoke test, too:
✅ Pattern / template part creation and patterns screens
✅ Navigation
✅ Document actions
✅ Added by
✅ New template part
✅ Template and template parts pages
✅ Save hub
✅ Page and Pages screens
✅ Template actions
Once that empty file is removed, this LGTM! ✨
Follow up on #54484 to consolidate constants
ramonjd
force-pushed
the
update/edit-site-constants-part-2
branch
from
a2b821f to
929f1e5
Compare
|
Flaky tests detected in 929f1e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6258331378
|
ramonjd
force-pushed
the
update/edit-site-constants-part-2
branch
from
929f1e5 to
c759dd2
Compare
kevin940726
approved these changes
Sep 21, 2023
kevin940726
left a comment
kevin940726
left a comment
Member
There was a problem hiding this comment.
Thank you!
Just a tiny thing that would be nice to squeeze it in this PR but totally acceptable to do it in another PR too 😆.
…ttern/use-pattern-details.js Co-authored-by: Kai Hao <kevin830726@gmail.com>
mikachan
added
the
Backport to Gutenberg RC
mikachan
pushed a commit
that referenced
this pull request
Sep 25, 2023
…54586) * Initial commit: Follow up on #54484 to consolidate constants * More using constants instead of hard-coded strings * Rename TEMPLATE_CUSTOM_SOURCE to TEMPLATE_ORIGINS * Update packages/edit-site/src/components/sidebar-navigation-screen-pattern/use-pattern-details.js Co-authored-by: Kai Hao <kevin830726@gmail.com> --------- Co-authored-by: Kai Hao <kevin830726@gmail.com>
Member
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 988971a |
mikachan
removed
the
Backport to Gutenberg RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Hello!
This is a follow up to
The effort continues to consolidate constants. 🔨
❗ To reduce the amount of files and testing involved, this PR doesn't replace all instances of hard-coded strings. There will be more follow ups.
Why?
To centralize names for post types and so on. Ease of management. Giving search and replace a well-deserved rest.
How?
Replacing the following strings with constants
NAVIGATION_POST_TYPETEMPLATE_POST_TYPETEMPLATE_PART_POST_TYPETEMPLATE_CUSTOM_SOURCEPATTERN_TYPES.userTEMPLATE_ORIGINS.customTEMPLATE_ORIGINS.themeTEMPLATE_ORIGINS.pluginPATTERN_SYNC_TYPES.unsyncedTesting Instructions