Site editor: use constants rather than hard coded template strings (round 3)#54705
Merged
Conversation
ramonjd
added
[Type] Code Quality
|
Size Change: +118 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
Comment on lines
-38
to
+35
| const entityLabel = entityLabels[ entityType ] || entityLabels.wp_template; | ||
| const entityLabel = | ||
| POST_TYPE_LABELS[ entityType ] || | ||
| POST_TYPE_LABELS[ TEMPLATE_POST_TYPE ]; |
Contributor
There was a problem hiding this comment.
There is a very subtle change here — we can now match against TEMPLATE_PART_POST_TYPE to get the Template part label, which wasn't possible before. This seems like a good change to me 👍
| Trunk | This PR |
|---|---|
 |
 |
I noticed one of the Playwright tests was failing. I've just kicked it off again, but if it's still failing, perhaps due to this label being updated?
This is the line where I think it might need to be updated to Template part?
Member
Author
There was a problem hiding this comment.
Thanks for tracking it down! I just pushed and walked away :D
It makes me realize how many variations of Template part, template part and Template Part we have across the codebase.
I've updated to match the constant for now (Template Part). This was what I gleaned from https://make.wordpress.org/marketing/handbook/resources/style-guide-and-brand-book/#capitalizing-wordpress-terms.
I can make a note to unify them once we decide on what it should be 😄
Contributor
There was a problem hiding this comment.
It makes me realize how many variations of Template part, template part and Template Part we have across the codebase.
Oh, good point! At least this e2e test is case insensitive so it shouldn't break when we unify them further down the track 🙂
andrewserong
approved these changes
Sep 22, 2023
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Looking good! Thanks for your "constant" vigilance in improving the code quality here 😄
All testing nicely for me, LGTM! ✨
Member
Author
The quality is "variable", but I appreciate your support |
ramonjd
added
the
Backport to Gutenberg RC
mikachan
pushed a commit
that referenced
this pull request
Sep 25, 2023
…ound 3) (#54705) * Another round of replacing hard-coded strings with available constants * Update E2E test selector match the label
Member
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: cd358e4 |
mikachan
removed
the
Backport to Gutenberg RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow up to:
Why?
To centralize names for post types and so on. Ease of management. Giving search and replace a well-deserved rest.
How?
Replacing the following strings with constants
NAVIGATION_POST_TYPETEMPLATE_POST_TYPETEMPLATE_PART_POST_TYPEPATTERN_TYPES.userTesting Instructions