Skip to content

Patterns: Reset current page when search filters change #52933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 2 commits into from
Jul 26, 2023
Merged

Patterns: Reset current page when search filters change #52933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b7319
Patterns: Reset current page when search filters change
aaronrobertshaw Jul 25, 2023
3964156
Update the current page on value change rather than with a useEffect
glendaviesnz Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions packages/edit-site/src/components/page-patterns/patterns-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,16 @@ export default function PatternsList( { categoryId, type } ) {
}
);

Comment thread
aaronrobertshaw marked this conversation as resolved.
const updateSearchFilter = ( value ) => {
setCurrentPage( 1 );
setFilterValue( value );
};

const updateSyncFilter = ( value ) => {
setCurrentPage( 1 );
setSyncFilter( value );
};

const id = useId();
const titleId = `${ id }-title`;
const descriptionId = `${ id }-description`;
Expand All @@ -90,14 +100,12 @@ export default function PatternsList( { categoryId, type } ) {
const pageIndex = currentPage - 1;
const numPages = Math.ceil( patterns.length / PAGE_SIZE );

const list = useMemo(
() =>
patterns.slice(
pageIndex * PAGE_SIZE,
pageIndex * PAGE_SIZE + PAGE_SIZE
),
[ pageIndex, patterns ]
);
const list = useMemo( () => {
return patterns.slice(
pageIndex * PAGE_SIZE,
pageIndex * PAGE_SIZE + PAGE_SIZE
);
}, [ pageIndex, patterns ] );

const asyncList = useAsyncList( list, { step: 10 } );

Expand Down Expand Up @@ -138,7 +146,9 @@ export default function PatternsList( { categoryId, type } ) {
<FlexBlock className="edit-site-patterns__search-block">
<SearchControl
className="edit-site-patterns__search"
onChange={ ( value ) => setFilterValue( value ) }
onChange={ ( value ) =>
updateSearchFilter( value )
}
placeholder={ __( 'Search patterns' ) }
label={ __( 'Search patterns' ) }
value={ filterValue }
Expand All @@ -152,7 +162,7 @@ export default function PatternsList( { categoryId, type } ) {
label={ __( 'Filter by sync status' ) }
value={ syncFilter }
isBlock
onChange={ ( value ) => setSyncFilter( value ) }
onChange={ ( value ) => updateSyncFilter( value ) }
__nextHasNoMarginBottom
>
{ Object.entries( SYNC_FILTERS ).map(
Expand Down