Patterns: Reset current page when search filters change#52933
Merged
aaronrobertshaw merged 2 commits intoJul 26, 2023
Conversation
aaronrobertshaw
added
[Type] Bug
|
Size Change: +322 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Contributor
Author
|
The console error thrown due to hooks running after DOM elements have been removed will be addressed via a separate PR. I've updated the PR description to match. |
aaronrobertshaw
changed the title
92 tasks
Contributor
Author
|
The error and crash while searching filtered patterns has been fixed in #52956. I think we are right to move forward with landing this fix as well. |
glendaviesnz
approved these changes
Jul 26, 2023
glendaviesnz
left a comment
glendaviesnz
left a comment
Contributor
There was a problem hiding this comment.
Tested well for me, always returned to page 1 when toggling the sync status or updating the search term.
Member
|
Hi folks. I just tried to cherry pick this PR to: But it relies on code in trunk that has not yet been merged to the wp/6.3 branch, e.g., code from #52663 So I had to leave it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #52926
What?
Resets the current page of pattern results when search term or sync status filters are updated to ensure results are shown.
Why?
Searching patterns isn't much use if it can only be done on the first page of results.
How?
Resets the current page state when search term or filters change.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-07-26.at.9.06.18.am.mp4