Skip to content

E2E: Fix draggable block tests #43739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WunderBart wants to merge 7 commits into from
Closed

E2E: Fix draggable block tests #43739

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b9866c
Test: See if clearing session storage fixes draggable block tests
WunderBart Aug 31, 2022
2386036
Check without clearing session storage
WunderBart Aug 31, 2022
a139585
Run all the specs
WunderBart Aug 31, 2022
846d54b
cleanup
ciampo Aug 31, 2022
7ec02bf
Remove old comments
ciampo Sep 1, 2022
6f31f92
Try keeping animations disabled to see if blocks are added
talldan Sep 3, 2022
3168646
Revert "Try keeping animations disabled to see if blocks are added"
talldan Sep 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions packages/e2e-tests/specs/editor/various/draggable-block.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,12 @@ import {
deactivatePlugin,
activatePlugin,
showBlockToolbar,
setBrowserViewport,
waitForWindowDimensions,
clickBlockAppender,
} from '@wordpress/e2e-test-utils';

describe.skip( 'Draggable block', () => {
// Tests don't seem to pass if beforeAll and afterAll are used.
// Unsure why.
beforeEach( async () => {
describe( 'Draggable block', () => {
beforeAll( async () => {
await deactivatePlugin(
'gutenberg-test-plugin-disables-the-css-animations'
);
Expand All @@ -24,15 +21,15 @@ describe.skip( 'Draggable block', () => {
// Scrolling can interfere with the drag coordinates.
await page.setViewport( { width: 960, height: 1024 } );
await waitForWindowDimensions( 960, 1024 );
await createNewPost();
await page.setDragInterception( true );
} );

afterEach( async () => {
await page.setDragInterception( false );
beforeEach( async () => {
await createNewPost();
} );

// Reset the viewport to normal large size.
await setBrowserViewport( 'large' );
Comment thread
WunderBart marked this conversation as resolved.
afterAll( async () => {
await page.setDragInterception( false );
await activatePlugin(
'gutenberg-test-plugin-disables-the-css-animations'
);
Expand Down