E2E: Fix draggable block tests#43739
Closed
WunderBart wants to merge 7 commits into
Closed
Conversation
|
Size Change: -17 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Aug 31, 2022
WunderBart
changed the title
ciampo
added
[Type] Automated Testing
ciampo
approved these changes
Aug 31, 2022
ciampo
left a comment
ciampo
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM!
Let's hope that this change is enough to fix the test flakiness.
| } from '@wordpress/e2e-test-utils'; | ||
|
|
||
| describe( 'Draggable block', () => { | ||
| // Tests don't seem to pass if beforeAll and afterAll are used. |
Member
There was a problem hiding this comment.
Reminder to remove this comment before merging :)
ciampo
force-pushed
the
fix/e2e-draggable-block-tests
branch
from
8877a24 to
7ec02bf
Compare
Contributor
|
It still seems to be failing. The test seems to not add any blocks at all, so I wonder why that is. It currently follows the same flow as many other tests by using the Perhaps there's an issue with |
Contributor
Until recently, that test was pressing The main issue here, as you also said, is that the snapshot being returned doesn't have any blocks:
A couple more interesting things that can be noted from the snapshot images taken on CI for the failed test:
Another thing that I noticed from the snapshots, is that the post ID always skip a number, i.e 151, 153, 155, 157 ... which suggest that there may be other posts created between each test? Is that because of other tests being run concurrently? In that case, could we see if running only this test spec changes anything? Or is this test spec somehow creating 2 new posts every time, instead of one (which could also explain why the new post is empty? Just a few wild guesses. |
Contributor
I decided to do some trial and error. I pushed a commit that comments out the deactivation of the animation plugin (so now the animations are turned off), and the blocks are now present in the failure artefact: So it seems as though it is related to css animations, but I'm not sure what.
This might be from |
This reverts commit 6f31f92.
Contributor
|
This is now fixed by #43798 (the tests have been migrated to Playwright) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #43737
This is an attempt to make the draggable block tests pass. I've noticed that before- and after- hooks were incorrectly used:
gutenberg-test-plugin-disables-the-css-animationsshould not be in the beforeEach hook, andTesting Instructions
I've re-run E2E jobs 3 times to be sure this fixes the draggable block tests.