DropdownMenu: use KeyboardEvent.code, refactor tests to model RTL and user-event#43439
Merged
Conversation
ciampo
added
[Type] Enhancement
Contributor
Author
ciampo
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
refactor/dropdown-menu-keycode-code
branch
from
2171b5b to
c68d805
Compare
tyxla
approved these changes
Aug 22, 2022
tyxla
left a comment
tyxla
left a comment
Member
There was a problem hiding this comment.
Looks good 👍 Needs a rebase, otherwise ready to ship IMO 🚀
Contributor
Author
dcalhoun
added
the
Mobile App - Automation
Member
👋🏻 @ciampo. I would be happy to review/test — it is on my todo list — but I made need a couple of days before I can dedicate time to this. I went ahead and triggered additional mobile CI tests. |
Contributor
Author
That's great to hear! I'll wait for your review, then (this is not a high-priority PR anyway, so no need to rush!) |
dcalhoun
approved these changes
Aug 23, 2022
Member
There was a problem hiding this comment.
🚀 LGTM. I left one comment for context, but it is not a blocker.
I tested the Heading level, Alignment (horizontal and vertical), and Justification dropdown menus on an iPhone SE and Samsung Galaxy S20. I believe those are the only locations leveraging DropdownMenu currently.
Thank you for pinging the native team. 🙇🏻
ciampo
force-pushed
the
refactor/dropdown-menu-keycode-code
branch
from
bf22040 to
f461f65
Compare
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
ciampo
force-pushed
the
refactor/dropdown-menu-keycode-code
branch
from
67b3812 to
79c31db
Compare
dcalhoun
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refactor the
DropdownMenucomponent to rely oncodeinstead ofkeyCodefor keyboard events.Since some tests were failing because they were relying on
fireEvent, I went ahead and refactored them to usinguserEventand with "modern" RTL style (i.e. avoiding implementation details).Why?
keyCodeis deprecated, and replaced bycodeHow?
Easy swap of values
Testing Instructions
In Storybook, visit the
DropdownMenustory and make sure that the dropdown opens when focusing its toggle button and pressing the arrow down key.