Autocomplete: use KeyboardEvent.code instead of KeyboardEvent.keyCode#43432
Merged
Conversation
|
Size Change: -38 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ciampo
added
[Type] Enhancement
ciampo
commented
Aug 19, 2022
ciampo
changed the title
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Member
|
Hey there 👋 is there an issue tracking these changes related to the Thank you! |
Member
|
@geriux could you please provide more information as to what broke? AFAIK there's not an issue, but these are the PRs in that direction on which we have worked so far:
|
Member
Sure! On mobile, we pass I've already created a PR to include this for the RichText component on mobile, which fixes the Autocomplete (slash inserter).
Thanks! I'll check that list. |
Contributor
Author
|
This one was also a PR related to this work: I didn't imagine this work would cause issues on the native side, since |
Member
No worries! I'll check those PRs to see if we need to update anything, thanks for sharing the list! |
This was referenced Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Refactor the
Autocompletecomponent to rely oncodeinstead ofkeyCodefor keyboard eventsWhy?
keyCodeis deprecated, and replaced bycodeHow?
Easy swap of values
Testing Instructions
The autocomplete component can be tested in the block editor in rich text blocks (e.g. autocompleting a user after typing
@) — in particular, the arrow keys, the enter key, and the escape keyMake sure that there are no regressions compared to how the component behaves on
trunk