ComboboxControl: refactor onKeyDown to use keyboardEvent.code#42569
Merged
Conversation
chad1008
added
[Package] Components
ciampo
approved these changes
Jul 20, 2022
ciampo
left a comment
ciampo
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀
Can we add a CHANGELOG entry too ?
|
Size Change: +115 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Contributor
Author
|
CHANGELOG updated! Thanks @ciampo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #42403
What?
Replace
ComboboxControl's use of imported@wordpress/keycodeswithkeyboardEvent.codevalues for relevant key presses.Why?
The
ComboboxControlcomponent'sonKeyDownmethod currently imports several keycodes from@wordpress/keycodes. This turned out to be problematic while writing unit tests, because newer tools liketesting-librabryrely onkeyboardEvent.codeorkeyboardEvent.keyfor keypress events.How?
Removing the current imports and replacing the key values with the corresponding
keyboardEvent.codevalues.kudos to @ciampo for guiding me to the solution on this one 🎉
Testing Instructions
Launch Storybook and test the
ComboboxControlcomponent using keypresses.Tabto focus the componentArrowUpandArrowDownto navigateEnterto selectEscapeto collapse without selecting