E2E Tests: Fix failing image e2e test by waiting for required element#36982
Merged
Conversation
glendaviesnz
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
Member
|
I also tested 23db42264d1029361fa93cc7ec3fb3520492872f, which reinstates the test from #36446 They're passing locally for me. 🤞 for the CI results. |
aaronrobertshaw
approved these changes
Nov 30, 2021
aaronrobertshaw
left a comment
aaronrobertshaw
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
The latest waitForImage approach tests well for me and passes reliably locally. For what it's worth, the previous waitForSelector approach failed consistently for me locally.
glendaviesnz
force-pushed
the
fix/image-e2e-test
branch
from
b7a6274 to
cdbe93a
Compare
7 tasks
Member
|
Thanks for working on this, @glendaviesnz 🌟 I'm going to restart e2e tests and merge this once all checks are green. Then, we can address other flaky tests separately. |
Contributor
@andrewserong and I have been testing this locally and finding the remaining image e2es are failing intermittently. Every other run to be precise. We might need a little luck to get all green checks 🤞 |
Member
Or we could use administrator privileges and merge it anyways. It only will make the current status of e2e tests better 😄 |
Member
|
This error is the current reason for test failure. I've seen it a dozen times in the last couple of days but cannot reproduce it locally. Error |
Contributor
I wasn't looking to push that option given locally I'm getting more failures on this branch than before. Given the inconsistency, if merging this lets us narrow the investigation, I'm fine with that 🙂 Here's some of the errors we're seeing locally
|
Contributor
|
I think I have an idea for what could be causing the failing I'll push a commit shortly. Edit: pushed in 2eb00f2 The hunch is that there's a couple of things at play. I suspect that doing things like the following might cause an issue for React controlled components (because we're updating the value of input field from outside of React): So, it could be more appropriate for us to try to clear fields as a user would? Then, the other thing at play is how quickly the UI will let us type. Adding in a delay appears to help reliability when running the tests locally, but as Aaron mentions, we're still experiencing intermittent failures 🤔 |
Contributor
Initially, this looked like it fixed the issue with I also still got the |
Merged
7 tasks
Comment on lines
347
to
348
Contributor
There was a problem hiding this comment.
Keeping the total delay overall the same but just using all of it to ensure the selection of the input field text has the e2es passing more reliably for me.
Suggested change
| await inputField.click( { clickCount: 3, delay: 100 } ); | |
| await page.keyboard.press( 'Backspace', { delay: 100 } ); | |
| await inputField.click( { clickCount: 3, delay: 200 } ); |
Contributor
|
@Mamaduka I haven't been able to get the checks green despite passing e2es locally. We might need to merge this with admin privileges after all so at least the PHP unit tests are fixed. I've run out of time today but I've dropped a comment pointing to this PR in the |
Member
|
Sounds good, @aaronrobertshaw 👍 |
Member
|
I ran the E2E tests locally on fresh |
Contributor
This is curious. Seems to be the whole test suite failing to run. Is it some kind of issue with authentication since |
Member
That's also my best guess, maybe issue with auth cookies. |
talldan
reviewed
Nov 30, 2021
Contributor
There was a problem hiding this comment.
This is passing in #36987. Might be worth enabling it again 😄
Contributor
The unsual thing is that it's only that image test and I see nothing special about it. Other than it possibly being the first test run in the series. |
talldan
force-pushed
the
fix/image-e2e-test
branch
from
2eb00f2 to
bcb9f40
Compare
Contributor
|
I merged the PHP test fix separately in #36987. Also rebased this and re-enabled the autocomplete tests as they now seem to be passing in trunk. |
talldan
force-pushed
the
fix/image-e2e-test
branch
from
bcb9f40 to
82727b6
Compare
… buttons, and by clicking image block wrapper to delete block
glendaviesnz
force-pushed
the
fix/image-e2e-test
branch
from
c7f6dd6 to
1902936
Compare
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
* Fix failing image e2e test by waiting for required element before attempting click * Switch to waiting for image instead of the image resize buttons in image block e2e tests * Add delay when clearing input field and typing replacement url in image e2e tests * Add in wait for user input box to prevent username being partially entered in mentions e2e test * Add phpunit-polyfills to fix running of php-unit tests locally - related to https://make.wordpress.org/core/2021/09/27/changes-to-the-wordpress-core-php-test-suite/ Co-authored-by: Glen Davies <glen.davies@a8c.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
7 tasks
This was referenced Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The image block e2e tests are consistently failing due to element not being visible when attempting to click. This fix adds a
page.waitForSelectorto ensure element is visible before attempting the click.There is also an update to the test for
Gutenberg_REST_Templates_Controller_Testthat updates thetest_create_itemtest to expect the author id in the response to match the id used to create the resource (self::$admin_id).How has this been tested?
Run
npm run test-e2e specs/editor/blocks/image.test.jslocally and make sure tests pass.