E2E Tests: Increase delay in image block e2e test to fix intermittent failure when clearing url field#37136
Merged
Conversation
…re when clearing url field
andrewserong
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
ramonjd
approved these changes
Dec 6, 2021
Contributor
Author
|
Thanks for testing @ramonjd! It's a small change, but 🤞 it improves reliability here a little bit. I'll merge it in 👍 |
andrewserong
deleted the
update/image-block-e2e-test-to-increase-delay
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the suggestion from @aaronrobertshaw in #36982 (comment) to increase the delay when clearing the input field in the Image block's e2e test. While testing locally, we noticed intermittent test failures in the clearing of the URL field, and slightly increasing the delay appears to improve the reliability without adding too much time to the test.
How has this been tested?
Locally, before checking out this PR, and after starting up
wp-envand runningnpm run dev, run the following:Before this PR, the tests pass for me most of the time. However, after running the above command 5 or 6 times, it starts to fail with the error shown in the screenshot below.
With this PR applied, the tests appear to pass consistently in my local environment.
Screenshots
This is the intermittent error message I would sometimes get prior to this PR. Note that in the "received" string, the UUID-based filename still appears in the URL and has not been cleared, so the target url has been appended to that string. In the expected string, the UUID filename is replaced with
/wp-includes/images/w-logo-blue.png.Types of changes
Code quality / test reliability.
Checklist:
*.native.jsfiles for terms that need renaming or removal).