Post Comments block: hide the "Comments Closed" message#35743
Merged
Conversation
jffng
added
the
[Block] Comments
|
Size Change: +5.33 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Contributor
|
I was seeing a notice when the attribute wasn't set. I added a commit to fix that. |
Contributor
|
I've been taking a look and it seems to be working fine! I think I am not the best person to review the code, but I checked how it works in the editor 🙂 .
Regarding this, there is still not progress on the Comments Template block, but this is for sure something to consider. I will post it there so it isn't missed. |
aristath
requested changes
Oct 21, 2021
Contributor
Author
|
Updated the PR based on the suggestion and logic described here, so no CSS is needed. I also updated the original PR description. It should be ready for another review. |
Contributor
Author
|
Another thought — what if we got rid of the attribute altogether, and just returned early if comments are closed and there are no comments. |
Contributor
Yeah, this seems like the right move to me. |
jffng
changed the title
aristath
approved these changes
Oct 26, 2021
aristath
left a comment
aristath
left a comment
Member
There was a problem hiding this comment.
Thank you for the changes!
LGTM 👍
kjellr
approved these changes
Oct 26, 2021
kjellr
left a comment
kjellr
left a comment
Contributor
There was a problem hiding this comment.
This works well in my testing too. Should be good to merge once tests pass. 👍
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
jffng
force-pushed
the
add/comments-closed-attribute
branch
from
e102ee4 to
0c19d32
Compare
7 tasks
gziolo
added
[Block] Comments (legacy)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves #35732.
This PR changes the Post Comments rendering to hide the "Comments are closed" message when the following conditions are met:
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).