This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Blockbase: Remove .nocomments fix#4913
Merged
Merged
Conversation
MaggieCabrera
approved these changes
Oct 27, 2021
MaggieCabrera
left a comment
MaggieCabrera
left a comment
Contributor
There was a problem hiding this comment.
LGTM, let's move it to the queue of do not merge PRs :D
Contributor
|
Note: Waiting for Gutenberg 9.x to land on wpcom simple before merging. |
scruffian
force-pushed
the
blockbase-remove-nocomments-fix
branch
from
da2b078 to
2b9322c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do no merge until Gutenberg 11.9.0 is on wpcom
Changes proposed in this Pull Request:
Now that WordPress/gutenberg#35743 has been merged, I believe we can remove the rule for hiding the
.nocommentscontainer.To test, make sure the 'comments are closed' message still doesn't appear if there are no comments and comments are closed. (With the GB PR, this container won't render at all.)