Fix menu item padding regression.#34435
Merged
Merged
Conversation
jasmussen
added
the
[Type] Regression
jasmussen
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
7 tasks
|
Size Change: -64 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 1, 2021
andrewserong
left a comment
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Excellent, thanks for the quick fix @jasmussen, much appreciated!
✅ The Edit/Select tool dropdown no longer has a scrollbar
✅ The media replace dropdown no longer has a scrollbar
✅ The dropdown menu items no longer have a scrollbar
Did a quick search in the codebase for other instances of -$grid-unit-15 but they all appear to be unrelated to the popover content children, so I think this catches them all. LGTM! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #34378 (comment).
A change to simplify and unify dropdown menu item padding failed to accommodate further customizations done in other components. This caused a horizontal scrollbar to appear in some popovers. This PR follows up and hopefully catches the remaining issues.
How has this been tested?
Please test dropdown menus and elements that use the popover component across the board, but notably these three:
Screenshots
The issue is fixed in these:
Checklist:
*.native.jsfiles for terms that need renaming or removal).