Try: Simplify & polish heading levels.#34378
Merged
Merged
Conversation
jasmussen
added
the
[Type] Code Quality
|
Size Change: -293 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
gwwar
approved these changes
Aug 30, 2021
gwwar
left a comment
gwwar
left a comment
Contributor
There was a problem hiding this comment.
Tests well for me! ✨ for code removal as well
Contributor
|
Just carrying over the conversation from #34406, it looks like this PR introduced a regression for a number of components that add a negative margin to offset the Scrollbars introduced:
@jasmussen do we want to work through those instances that need their negative margins updated (I'm happy to open a couple of PRs, I already updated the drop down menu component in #34406). Alternately, did we want to update the Heading dropdown to use its own negative margins instead of globally updating padding for the children of the popover content? Happy to help out! |
7 tasks
Contributor
Author
|
Thanks for the help tracking that down. I've created #34435 to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup to #32926, this one tries to polish the heading level dropdown a little bit and simplify some code. The min width is no longer necessary, and the padding was too tight. Before:
This PR removes, and therefore unifies, some of the rules, and reduces the padding a bit to compensate:
At first glance the vertical toolbar looks like it has too much padding at this point. But give it a moment, I think it works alright.
Checklist:
*.native.jsfiles for terms that need renaming or removal).