Clamp enumByteSize read count to prevent global buffer overflow - #1232
Open
acato wants to merge 1 commit into
Open
Clamp enumByteSize read count to prevent global buffer overflow#1232acato wants to merge 1 commit into
acato wants to merge 1 commit into
Conversation
The savegame reader writes attacker-controlled bytes into the enumByteSize[NUM_SAVEGAME_CLASS_TYPES] global array using a byte count read from the savegame (0-255), but the array only has 23 entries. A crafted savegame overwrites adjacent globals, corrupting the conversion table and enabling controlled memory corruption. Fixes We-the-People-civ4col-mod#1229 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iSizebyte read from the savegame toNUM_SAVEGAME_CLASS_TYPES(23) before using it as a loop bound for writing into theenumByteSizeglobal arrayiSizeup to 255, overwriting 232 bytes of adjacent globals — including the conversion table that controls all subsequent deserializationFixes #1229
Test plan
🤖 Generated with Claude Code