Fix remote crash from negative PlayerTypes in CvNetwork::receive() - #1227
Open
acato wants to merge 1 commit into
Open
Fix remote crash from negative PlayerTypes in CvNetwork::receive()#1227acato wants to merge 1 commit into
acato wants to merge 1 commit into
Conversation
Reject invalid (negative or out-of-range) player IDs at the top of the network receive handler. The signed-to-unsigned comparison with vector::size() caused -1 to be interpreted as 4 billion, triggering an infinite loop of push_back that exhausted the 32-bit address space. Fixes We-the-People-civ4col-mod#1225 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CvNetwork::receive()to reject invalid player IDs (< 0or>= MAX_PLAYERS) before they reach the signed-to-unsigned comparison withvector::size()ePlayer(e.g.NO_PLAYER = -1) is implicitly cast to~4 billionwhen compared to the unsignedsize_t, causing an infinitepush_backloop that exhausts the 32-bit address space and crashes the gameFixes #1225
Test plan
🤖 Generated with Claude Code