Founding Fathers Name Updates - #1077
Open
mistakingover wants to merge 2 commits into
Open
Conversation
Fixing in different language names for Founding Fathers. Johann Moritz line (4108) left intact, but his name in code should be changed to reflect the correct english name, akin to the standirization used with other fathers. As I have no knowledge on how this would affect other areas of the code, left it untouched, so only things that changed were how the names show in-game. Johann Moritz Pedia text also changed to reflect his Dutch name in all entries, as common in other Founding Fathers, having their original language name in the Pedia description. Also notice that the title Furst (Prince in German) was also changed in all lines to reflect the correct language of the text it's writen on, ending all possible mistakes when reading it.
More name language updates
Collaborator
|
undo the change for the TXT_KEY_FATHER_JOHANN_MORITZ tag for Russian and for the TXT_KEY_FATHER_IVAN_KRUZENSHTERN tag for all languages.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing in different language names for Founding Fathers.
Johann Moritz line (4108) left intact, but his name in code should be changed to reflect the correct english name, akin to the standirization used with other fathers.
As I have no knowledge on how this would affect other areas of the code, left it untouched, so only things that changed were how the names show in-game.
Johann Moritz Pedia text also changed to reflect his Dutch name in all entries, as common in other Founding Fathers, having their original language name in the Pedia description.
Also notice that the title Furst (Prince in German) was also changed in all lines to reflect the correct language of the text it's writen on, ending all possible mistakes when reading it.
More name language updates. Stopped since there seems to be a need in better representing the various nations of the continent, which deems updating FF's names to their correct names in different languages potentially redundant given the possibility of removal.
Will address such matters when the list of FF's is definite.