Skip to content

Founding Fathers Name Updates - #1077

Open
mistakingover wants to merge 2 commits into
We-the-People-civ4col-mod:developfrom
mistakingover:patch-1
Open

Founding Fathers Name Updates#1077
mistakingover wants to merge 2 commits into
We-the-People-civ4col-mod:developfrom
mistakingover:patch-1

Conversation

@mistakingover

Copy link
Copy Markdown

Fixing in different language names for Founding Fathers.
Johann Moritz line (4108) left intact, but his name in code should be changed to reflect the correct english name, akin to the standirization used with other fathers.
As I have no knowledge on how this would affect other areas of the code, left it untouched, so only things that changed were how the names show in-game.
Johann Moritz Pedia text also changed to reflect his Dutch name in all entries, as common in other Founding Fathers, having their original language name in the Pedia description.
Also notice that the title Furst (Prince in German) was also changed in all lines to reflect the correct language of the text it's writen on, ending all possible mistakes when reading it.

More name language updates. Stopped since there seems to be a need in better representing the various nations of the continent, which deems updating FF's names to their correct names in different languages potentially redundant given the possibility of removal.
Will address such matters when the list of FF's is definite.

Fixing in different language names for Founding Fathers.
Johann Moritz line (4108) left intact, but his name in code should be changed to reflect the correct english name, akin to the standirization used with other fathers.
As I have no knowledge on how this would affect other areas of the code, left it untouched, so only things that changed were how the names show in-game.
Johann Moritz Pedia text also changed to reflect his Dutch name in all entries, as common in other Founding Fathers, having their original language name in the Pedia description.
Also notice that the title Furst (Prince in German) was also changed in all lines to reflect the correct language of the text it's writen on, ending all possible mistakes when reading it.
More name language updates
@MrZorG33

MrZorG33 commented Feb 3, 2025

Copy link
Copy Markdown
Collaborator

undo the change for the TXT_KEY_FATHER_JOHANN_MORITZ tag for Russian and for the TXT_KEY_FATHER_IVAN_KRUZENSHTERN tag for all languages.

  1. I am translating into Russian based on the information I have (in Russian), and if something needs to be corrected, I will do it myself.
  2. Although Kruzenshtern had the name you indicated at birth, he took a Russian name in his youth and was subsequently called by that name everywhere, since he was a Russian navigator, although he was not one at birth. His original name can be indicated in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants