Skip to content

change status code #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oskargawr wants to merge 1 commit into from
Closed

change status code #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/main/java/share/fare/backend/service/ExpenseService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ void validateExpenseRequest(ExpenseRequest expenseRequest) {
private void validateUserSplitsBelongToGroup(Group group, Map<Long, BigDecimal> userSplits) {
for (Long userId : userSplits.keySet()) {
if (!groupMembershipRepository.existsByGroupAndUser_Id(group, userId)) {
throw new InvalidExpenseException("User with ID " + userId + " is not a member of the group.");
throw new ActionIsNotAllowedException("User with ID " + userId + " is not a member of the group.");

@gemini-code-assist gemini-code-assist Bot Jun 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider reverting to InvalidExpenseException or using a more specific exception that aligns with data validation errors. ActionIsNotAllowedException typically indicates an authorization failure (HTTP 403), while this scenario is a data validation issue (user not in group). A 400 Bad Request might be more appropriate.

Suggested change
throw new ActionIsNotAllowedException("User with ID " + userId + " is not a member of the group.");
throw new InvalidExpenseException("User with ID " + userId + " is not a member of the group.");

}
}
}
Expand Down
Loading