change status code

[oskargawr]

Summary by Sourcery

Bug Fixes:

• Use ActionIsNotAllowedException instead of InvalidExpenseException when a user split refers to a non-group member

[sourcery-ai]

Reviewer's Guide

Refactor exception handling in ExpenseService to use ActionIsNotAllowedException for unauthorized user group membership

Class diagram for updated exception handling in ExpenseService

classDiagram
    class ExpenseService {
        - validateUserSplitsBelongToGroup(Group group, Map<Long, BigDecimal> userSplits)
    }
    class InvalidExpenseException
    class ActionIsNotAllowedException
    ExpenseService ..> ActionIsNotAllowedException : throws
    %% Previously: ExpenseService ..> InvalidExpenseException : throws (replaced)

Loading

File-Level Changes

Change	Details	Files
Replace InvalidExpenseException with ActionIsNotAllowedException	Change thrown exception type in user-splits validation	backend/src/main/java/share/fare/backend/service/ExpenseService.java

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @oskargawr, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling within the expense service by updating the type of exception thrown for specific authorization-related failures. The change aims to provide clearer and more precise error semantics when a user attempts an action for which they lack the necessary group membership.

Highlights

• Error Handling Refinement: Replaced InvalidExpenseException with ActionIsNotAllowedException in the validateUserSplitsBelongToGroup method. This change ensures that when a user attempts to perform an action related to an expense for a group they are not a member of, a more semantically appropriate exception is thrown, indicating an unauthorized action rather than an invalid expense.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey @oskargawr - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

The pull request changes the exception thrown when an expense split includes a user who isn't a group member, from InvalidExpenseException to ActionIsNotAllowedException. I suggest considering whether the new exception accurately reflects the error condition, as it might be semantically confusing.

[gemini-code-assist]

Consider reverting to InvalidExpenseException or using a more specific exception that aligns with data validation errors. ActionIsNotAllowedException typically indicates an authorization failure (HTTP 403), while this scenario is a data validation issue (user not in group). A 400 Bad Request might be more appropriate.

Suggested change

	throw new ActionIsNotAllowedException("User with ID " + userId + " is not a member of the group.");
	throw new InvalidExpenseException("User with ID " + userId + " is not a member of the group.");