Fix 'Sign in to edit' dialog spacing and copy (inline edit prompt)#300
Open
texture-fleet-agent[bot] wants to merge 1 commit into
Open
Fix 'Sign in to edit' dialog spacing and copy (inline edit prompt)#300texture-fleet-agent[bot] wants to merge 1 commit into
texture-fleet-agent[bot] wants to merge 1 commit into
Conversation
- More welcoming title: 'Help improve CommonGrid' - Better spacing: space-y-6 p-6 (from space-y-4 p-4) + pt-2 on button row - More explanatory body text about what users can do after signing in - Larger text size for better mobile readability (text-base, leading-relaxed) Changes applied to: - components/entity/FieldList.tsx - components/detail/DetailFieldList.tsx - app/(shell)/grid-operators/[slug]/page.tsx
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the inline edit dialog (the one that appears when users click the pencil icon on entity pages) with better spacing and more welcoming copy. This is separate from PR #296, which addressed the Clerk auth page dialog.
Context
Nick reported cramped spacing on the "Sign in to edit" dialog that appears when clicking edit icons on entity pages (mobile screenshot showed iOS). PR #296 modified the wrong dialog (the Clerk auth page), so this PR fixes the correct one.
Changes
space-y-6 p-6(fromspace-y-4 p-4)pt-2on button row for extra separationtext-base leading-relaxed(fromtext-sm) for better mobile readabilityFiles Changed
components/entity/FieldList.tsxcomponents/detail/DetailFieldList.tsxapp/(shell)/grid-operators/[slug]/page.tsxAll three files had the same inline edit dialog pattern and have been updated consistently.
Testing
npm run lintpasses (exit code 0)npm run buildpasses (exit code 0)Verification Needed
Related