Improve sign-in dialog UI with better spacing and welcoming copy#296
Closed
texture-fleet-agent[bot] wants to merge 2 commits into
Closed
Improve sign-in dialog UI with better spacing and welcoming copy#296texture-fleet-agent[bot] wants to merge 2 commits into
texture-fleet-agent[bot] wants to merge 2 commits into
Conversation
- Add custom Clerk appearance configuration for consistent styling - Improve vertical spacing between dialog elements via spacingUnit - Make copy more welcoming and explanatory about what signing in enables - Add custom localization for sign-in and sign-up modals - Style elements to match CommonGrid design system - Ensure mobile-friendly with proper spacing and rounded corners Fixes spacing and copy issues reported in mobile screenshot feedback.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Closing — this PR modified the Clerk auth modal, but Nick's screenshot was actually the inline "Sign in to edit" dialog rendered by FieldList.tsx / DetailFieldList.tsx / grid-operators/[slug]/page.tsx. The correct fix shipped as #300. Lesson logged in tonight's reflection (LEARNINGS 2026-05-31). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the Clerk sign-in dialog UI based on Nick's feedback. The dialog now has better spacing, more welcoming copy, and is more explanatory about what signing in enables.
Changes
spacingUnit: '1rem'Testing
npm run lintpasses (pre-existing warnings unrelated to this change)npm run buildpasses (exit code 0)Before/After
Before: Cramped spacing, minimal explanation of what signing in enables
After:
mb-2,mb-6, and increasedspacingUnitRelated
Addresses feedback from Nick's mobile screenshot showing poor spacing and insufficient explanation.