Audio | Forge - Fix audio & actions#277
Merged
Merged
Conversation
- title, fixed sfx never initializing on forges, also moved the ACE interaction to be more towards the forges coals than floating above it for immersion - removed `assets` preInit for forge sfx audio, moved it into the `forge` component - removed `forgeAudioList` gvar in `audio` postInit, never used - added small delays to forge audio init to make sure `createSoundSource` properly syncs to objects
Closed
Mike-MF
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
title, fixed sfx never initializing on forges, also moved the ACE interaction to be more towards the forges coals than floating above it for immersion
removed
assetspreInit for forge sfx audio, moved it into theforgecomponentremoved
forgeAudioListgvar inaudiopostInit, never usedadded small delays to forge audio init to make sure
createSoundSourceproperly syncs to objectsIMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.