Tag rulesets: restore non_fast_forward - #3
Merged
Conversation
Copying conceit's release-tags-immutable dropped non_fast_forward, which directed-contexts and security-context-spec both had before. That is a straight downgrade to tag protection: without it a tag can be moved by force-push, which is exactly what an immutable release tag exists to prevent. Added to every tag ruleset here so no repo is weaker than it was, and so the rule is uniform rather than depending on which repo the definition was copied from. Note: conceit's own tag ruleset still lacks it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying
conceit'srelease-tags-immutabledropped thenon_fast_forwardrule.directed-contextsandsecurity-context-specboth had it before, so for those two this is a regression fix; for the others it closes the same gap before it matters.Without
non_fast_forward, a tag can be moved by force-push — which is precisely what an immutable release tag exists to prevent.updateanddeletionalone do not cover it.Applied to every tag ruleset in this repo so no repo ends up weaker than it was, and so the rule doesn't depend on which repo a definition happened to be copied from.
Not yet applied to the live ruleset — the files change here first; the
gh apiapply is a separate step once this merges.Note:
conceit's own tag ruleset still lacksnon_fast_forwardand is untouched.