Tag rulesets: add non_fast_forward - #4
Merged
Merged
Conversation
release-tags-immutable had update, deletion and required_signatures but not non_fast_forward, so a release tag could still be moved by force-push -- which is the thing an immutable tag exists to prevent. update and deletion do not cover it. This repo is the shape the others were normalized to, so the gap propagated: directed-contexts and security-context-spec both HAD non_fast_forward until they were made consistent with this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-tags-immutablehasupdate,deletionandrequired_signatures, but notnon_fast_forward— so a release tag can still be moved by force-push, which is exactly what an immutable tag exists to prevent.updateanddeletiondo not cover that case.This repo is the shape the other four were normalized to, so the gap propagated outward:
directed-contextsandsecurity-context-specboth hadnon_fast_forwarduntil they were made consistent with this file. Companion PRs restore it there:Files only — the live ruleset is unchanged; applying via
gh apiis a separate step after merge.