Skip to content

Ignore no-jquery errors with inline comments #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Jan 6, 2026
Merged

Ignore no-jquery errors with inline comments #2723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,14 @@
"no-jquery/no-prop": "error",
"no-jquery/no-filter": "error",
"no-jquery/no-data": "error",
"no-jquery/no-parents": "error"
"no-jquery/no-parents": "error",
"no-jquery/no-val": "error",
"no-jquery/no-serialize": "error",
"no-jquery/no-class": "error",
"no-jquery/no-closest": "error",
"no-jquery/no-ajax": "error",
"no-jquery/no-fade": "error",
"no-jquery/no-is": "error"
}
}
]
Expand Down
20 changes: 10 additions & 10 deletions js/formidable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ function frmFrontFormJS() {
return errors;
}

val = jQuery( field ).val();
val = jQuery( field ).val(); // eslint-disable-line no-jquery/no-val

if ( val === null ) {
val = '';
Expand Down Expand Up @@ -851,7 +851,7 @@ function frmFrontFormJS() {
const fieldsets = object.querySelectorAll( '.frm_form_field' );
fieldsets.forEach( field => field.classList.add( 'frm_doing_ajax' ) );

data = jQuery( object ).serialize() + '&action=frm_entries_' + action + '&nonce=' + frm_js.nonce; // eslint-disable-line camelcase
data = jQuery( object ).serialize() + '&action=frm_entries_' + action + '&nonce=' + frm_js.nonce; // eslint-disable-line no-jquery/no-serialize, camelcase
shouldTriggerEvent = object.classList.contains( 'frm_trigger_event_on_submit' );

const doRedirect = response => {
Expand Down Expand Up @@ -923,7 +923,7 @@ function frmFrontFormJS() {
const formIdInput = object.querySelector( 'input[name="form_id"]' );
formID = formIdInput ? formIdInput.value : '';
response.content = response.content.replace( / frm_pro_form /g, ' frm_pro_form frm_no_hide ' );
replaceContent = jQuery( object ).closest( '.frm_forms' );
replaceContent = jQuery( object ).closest( '.frm_forms' ); // eslint-disable-line no-jquery/no-closest
removeAddedScripts( replaceContent, formID );
delay = maybeSlideOut( replaceContent, response.content );

Expand Down Expand Up @@ -964,8 +964,8 @@ function frmFrontFormJS() {
$fieldCont = fieldContEl ? jQuery( fieldContEl ) : jQuery();

if ( $fieldCont.length ) {
if ( ! $fieldCont.is( ':visible' ) ) {
inCollapsedSection = $fieldCont.closest( '.frm_toggle_container' );
if ( ! $fieldCont.is( ':visible' ) ) { // eslint-disable-line no-jquery/no-is
inCollapsedSection = $fieldCont.closest( '.frm_toggle_container' ); // eslint-disable-line no-jquery/no-closest
if ( inCollapsedSection.length ) {
frmTrigger = inCollapsedSection.prev();
if ( ! frmTrigger.hasClass( 'frm_trigger' ) ) {
Expand All @@ -976,7 +976,7 @@ function frmFrontFormJS() {
}
}

if ( $fieldCont.is( ':visible' ) ) {
if ( $fieldCont.is( ':visible' ) ) { // eslint-disable-line no-jquery/no-is
addFieldError( $fieldCont, key, response.errors );
contSubmit = false;
}
Expand Down Expand Up @@ -1056,7 +1056,7 @@ function frmFrontFormJS() {
ajaxParams.error = error;
}

jQuery.ajax( ajaxParams );
jQuery.ajax( ajaxParams ); // eslint-disable-line no-jquery/no-ajax
}

function afterFormSubmitted( object, response ) {
Expand Down Expand Up @@ -1290,7 +1290,7 @@ function frmFrontFormJS() {
}

function showLoadingIndicator( $object ) {
if ( ! $object.hasClass( 'frm_loading_form' ) && ! $object.hasClass( 'frm_loading_prev' ) ) {
if ( ! $object.hasClass( 'frm_loading_form' ) && ! $object.hasClass( 'frm_loading_prev' ) ) { // eslint-disable-line no-jquery/no-class
addLoadingClass( $object );
$object.trigger( 'frmStartFormLoading' );
}
Expand All @@ -1299,7 +1299,7 @@ function frmFrontFormJS() {
function addLoadingClass( $object ) {
const loadingClass = isGoingToPrevPage( $object ) ? 'frm_loading_prev' : 'frm_loading_form';

$object.addClass( loadingClass );
$object.addClass( loadingClass ); // eslint-disable-line no-jquery/no-class
}

function isGoingToPrevPage( $object ) {
Expand Down Expand Up @@ -1332,7 +1332,7 @@ function frmFrontFormJS() {
const fileval = fileInput ? fileInput.value : '';
if ( fileval !== '' ) {
setTimeout( function() {
jQuery( loading ).fadeIn( 'slow' );
jQuery( loading ).fadeIn( 'slow' ); // eslint-disable-line no-jquery/no-fade
}, 2000 );
}
}
Expand Down