Ignore no-jquery errors with inline comments#2723
Conversation
WalkthroughChanges to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
js/formidable.js (1)
1059-1059: LGTM! Consider future refactoring.The eslint suppressions for
no-jquery/no-ajax,no-jquery/no-class, andno-jquery/no-fadeare correctly applied. These jQuery methods are appropriate given the current codebase architecture.Optional: Consider future refactoring
If reducing jQuery dependency is a long-term goal, these could eventually be replaced with native alternatives:
jQuery.ajax()→fetch()APIhasClass()/addClass()→classListAPIfadeIn()→ CSS transitions or Web Animations APIHowever, this is purely optional and not required for this PR, which correctly achieves its stated objective of suppressing the lint warnings.
Also applies to: 1293-1293, 1302-1302, 1335-1335
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
.eslintrc.jsonis excluded by!**/*.json
📒 Files selected for processing (1)
js/formidable.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: PHP 8 tests in WP 6.9
- GitHub Check: PHP 7.4 tests in WP 6.9
- GitHub Check: Cypress
- GitHub Check: PHP 8 tests in WP 6.9
- GitHub Check: PHP 7.4 tests in WP 6.9
- GitHub Check: Cypress
🔇 Additional comments (2)
js/formidable.js (2)
420-420: LGTM!The eslint suppressions for
no-jquery/no-valandno-jquery/no-serializeare appropriately applied to these jQuery method calls. The additionalcamelcasesuppression on line 854 correctly handles the externalfrm_js.nonceproperty.Also applies to: 854-854
926-926: LGTM!The eslint suppressions for
no-jquery/no-closestandno-jquery/no-isare correctly applied to the jQuery DOM traversal and visibility checking methods used in the form error handling logic.Also applies to: 967-968, 979-979
…inline_comments Ignore no-jquery errors with inline comments
This should help detect most new uses of jQuery that we want to block and it makes it easier to find which code needs to update.