Skip to content

feat: update commonware to 2026.5.0#442

Open
matthias-wright wants to merge 36 commits into
mainfrom
m/update-commonware-2026.5.0
Open

feat: update commonware to 2026.5.0#442
matthias-wright wants to merge 36 commits into
mainfrom
m/update-commonware-2026.5.0

Conversation

@matthias-wright

Copy link
Copy Markdown
Collaborator

Builds on #440.

Core Changes:

  • Bumps all commonware crates from 2026.4.0 to 2026.5.0.
  • Applies the API updates.
  • Updates the syncer with the recent marshal changes, specifically:
    • Introduces new modules:
      • floor.rs: processed floor as (height, round); all fetches gated by fetch_if_permitted, denying at/below either floor.
      • stream.rs: durable application-progress cursor (last acked height).
      • acks.rs: FIFO pipeline of in-flight application acks, capped by max_pending_acks.
      • delivery.rs: parsed deliveries held for batch certificate verification.
    • Uses the new commonware-actor crate to rebuild the mailbox.
    • Resolver now attaches a local annotation to each fetch which contains information about if the fetch is for a Notarization/Certified/Finalized and the corresponding round/height. This information can be used when processing the response, for example for discarding stale data.
    • Resolver no longer blocks on delivery.
    • The actor.rs run loop is now select_loop! with arms ordered.
    • Notarization arm no longer eagerly fetches a missing block

This update also fixes #357, #356, and #346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security][tentative] Medium (correctness): Syncer SetFloor Stale Round Fetches Below Floor

1 participant