test: freeze deposit-request golden vectors for client compatibility#443
Open
matthias-wright wants to merge 37 commits into
Open
test: freeze deposit-request golden vectors for client compatibility#443matthias-wright wants to merge 37 commits into
matthias-wright wants to merge 37 commits into
Conversation
…cle/edge-case tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #440 and #442.
The deposit request signature format changed in #282.
This PR freezes three signed deposit requests as
types/fixtures/deposit_requests.jsonin the 288-byte EL wire format, plus tests that pin both directions.The frozen deposit requests are used for testing the deposit request function in the client SDKs.
Changes:
committed_fixtures_match_generator: the file matches what the current signing/encoding code produces; any change to the wire format, signing message, or domain derivation fails here and forces a conscious regenfrozen_requests_parse_and_round_trip:try_from_eth_bytesparses the frozen bytes into exactly the recorded fields and re-encodes identicallyfrozen_requests_verify_and_process: the vectors pass signature verification and produce the expected validator accountsmutated_frozen_requests_are_rejected: corrupted signatures/amounts are rejected with the rightDepositRejectionReason; the index bytes are provably outside the signed message