Add mass matrix support for FIRK and MIRK#536
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Conversation
Add mass matrix handling for FIRK and MIRK collocation paths, including algebraic constraint application and DAE adaptivity guards. Add focused FIRK and MIRK DAE tests for simple index-1 problems and Ascher-Spiteri coverage. Co-Authored-By: Sebastian Micluța-Câmpeanu <sebastian.mc95@proton.me> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Benchmark Results (Julia v1.11)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Continues and rebases the mass matrix support from #521 onto current
masterwithout pushing to the contributor branch.What changed:
Local validation run on Julia
+1:timeout 3600 ~/.juliaup/bin/julia +1 --project=lib/BoundaryValueDiffEqMIRK -e 'import Pkg; Pkg.instantiate(); include("lib/BoundaryValueDiffEqMIRK/test/Core/dae_tests.jl")'Simple index-1 DAE: 30 passedAscher & Spiteri example problem 1: 8 passedMesh adaptivity is not supported for DAEs: 2 passedtimeout 3600 ~/.juliaup/bin/julia +1 --project=lib/BoundaryValueDiffEqFIRK -e 'import Pkg; Pkg.instantiate(); include("lib/BoundaryValueDiffEqFIRK/test/expanded/dae_tests.jl")'Simple index-1 DAE: 24 passedAscher & Spiteri example problem 1: 4 passedMesh adaptivity is not supported for DAEs: 2 passedtimeout 3600 ~/.juliaup/bin/julia +1 --project=lib/BoundaryValueDiffEqFIRK -e 'import Pkg; Pkg.instantiate(); include("lib/BoundaryValueDiffEqFIRK/test/nested/dae_tests.jl")'Simple index-1 DAE: 18 passedMesh adaptivity is not supported for DAEs: 2 passedtimeout 3600 ~/.juliaup/bin/julia +1 --project=.runic_env -m Runic --check --diff .passed with no diff;.runic_envwas removed after the check.