Skip to content

fix: validate key length in symmetricDecrypt #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SirDank wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: validate key length in symmetricDecrypt #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
</description>

<properties>
<maven.compiler.release>25</maven.compiler.release>
<maven.compiler.release>21</maven.compiler.release>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<javasteam.version>1.8.0</javasteam.version>
</properties>
Expand All @@ -40,7 +40,7 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>3.13.0</version>
<configuration>
<release>25</release>
<release>21</release>
</configuration>
</plugin>
<plugin>
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/in/dragonbra/javasteam/util/crypto/CryptoHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ public static byte[] symmetricDecrypt(byte[] input, byte[] key, Passable<byte[]>
if (key == null) {
throw new IllegalArgumentException("key is null");
}
if (key.length != 32) {
throw new IllegalArgumentException("SymmetricDecrypt used with non 32 byte key!");
}
try {
if (key.length != 32) {
logger.debug("SymmetricDecrypt used with non 32 byte key!");
}
// Step 1: the first 16 bytes are the IV, itself AES/ECB-encrypted with the key.
Cipher cipher = Cipher.getInstance("AES/ECB/NoPadding");
byte[] cryptedIv = Arrays.copyOfRange(input, 0, 16);
Expand Down