Skip to content

fix: validate key length in symmetricDecrypt#2

Open
SirDank wants to merge 1 commit into
mainfrom
fix-crypto-key-length-validation-13064811098211674903
Open

fix: validate key length in symmetricDecrypt#2
SirDank wants to merge 1 commit into
mainfrom
fix-crypto-key-length-validation-13064811098211674903

Conversation

@SirDank

@SirDank SirDank commented May 27, 2026

Copy link
Copy Markdown
Contributor

The symmetricDecrypt method in CryptoHelper.java was previously only logging a debug message when an invalid key length (!= 32 bytes) was provided, but continued with the invalid key length.

This change:

  • Replaces the debug log with throwing an IllegalArgumentException
  • Moves the check cleanly before the try block alongside the other argument validations

PR created automatically by Jules for task 13064811098211674903 started by @SirDank

…rypt

The symmetricDecrypt method was previously only logging a debug message
when an invalid key length (!= 32 bytes) was provided, which could lead
to errors later in execution.

This change moves the validation check alongside the existing null checks
before the try block, throwing an IllegalArgumentException immediately
if the key length is invalid.

Co-authored-by: SirDank <52797753+SirDank@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant