Skip to content

chore: Remove @Beta annotations #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharlesDuboisSAP wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: Remove @Beta annotations #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad47f95
chore: Remove `@Beta` annotations
CharlesDuboisSAP May 27, 2026
f63ee0f
chore: Remove `@Beta` annotations
CharlesDuboisSAP May 27, 2026
69320c5
chore: Remove `@Beta` annotations
CharlesDuboisSAP May 27, 2026
cf6cd68
jackson
CharlesDuboisSAP May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions core-services/document-grounding/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<!-- scope "provided" -->
<dependency>
<groupId>org.projectlombok</groupId>
Expand Down
2 changes: 0 additions & 2 deletions core-services/document-grounding/src/main/java/com/sap/ai/sdk/grounding/GroundingClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.sap.ai.sdk.grounding;

import com.google.common.annotations.Beta;
import com.sap.ai.sdk.core.AiCoreService;
import com.sap.ai.sdk.grounding.client.PipelinesApi;
import com.sap.ai.sdk.grounding.client.RetrievalApi;
Expand Down Expand Up @@ -84,7 +83,6 @@ public RetrievalApi retrieval() {
* @return a new client.
* @since 1.17.0
*/
@Beta
@Nonnull
public GroundingClient withHeader(@Nonnull final String key, @Nonnull final String value) {
final var newClient = new GroundingClient(this.service, this.basePath);
Expand Down
4 changes: 0 additions & 4 deletions core-services/prompt-registry/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
Expand Down
2 changes: 0 additions & 2 deletions ...ompt-registry/src/main/java/com/sap/ai/sdk/prompt/registry/OrchestrationConfigClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import com.fasterxml.jackson.annotation.JsonSubTypes;
import com.fasterxml.jackson.annotation.JsonTypeInfo;
import com.google.common.annotations.Beta;
import com.sap.ai.sdk.core.AiCoreService;
import com.sap.ai.sdk.prompt.registry.client.OrchestrationConfigsApi;
import com.sap.ai.sdk.prompt.registry.model.AzureContentSafetyInputFilterConfig;
Expand All @@ -23,7 +22,6 @@
*
* @since 1.15.0
*/
@Beta
public class OrchestrationConfigClient extends OrchestrationConfigsApi {
Comment on lines -26 to 27
Copy link
Copy Markdown
Member

@rpanackal rpanackal May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor)

Keep this beta tag since it extends unstable (generated) code

Copy link
Copy Markdown
Contributor Author

@CharlesDuboisSAP CharlesDuboisSAP May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We said generated code will not be annotated as Beta

Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We said generated code will not be annotated as Beta

Yes, but this is not generated code and also for users does not look like generated code. So the instability of the API might not be obvious to users.


/**
Expand Down
1 change: 0 additions & 1 deletion core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
* @param <R> The type of the error response.
* @since 1.1.0
*/
@Beta
@Slf4j
@RequiredArgsConstructor
public class ClientResponseHandler<T, R extends ClientError, E extends ClientException>
Comment thread
rpanackal marked this conversation as resolved.
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/java/com/sap/ai/sdk/core/common/ClientStreamingHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
* @param <R> The type of the error.
* @since 1.2.0
*/
@Beta
@Slf4j
public class ClientStreamingHandler<
D extends StreamedDelta, R extends ClientError, E extends ClientException>
Expand All @@ -31,6 +30,7 @@ public class ClientStreamingHandler<
* @return the current instance of {@link ClientStreamingHandler} with the changed object mapper
*/
@Nonnull
@Beta
public ClientStreamingHandler<D, R, E> objectMapper(@Nonnull final ObjectMapper jackson) {
super.objectMapper(jackson);
return this;
Expand Down
2 changes: 0 additions & 2 deletions core/src/main/java/com/sap/ai/sdk/core/common/RequestLogContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.sap.ai.sdk.core.common;

import com.google.common.annotations.Beta;
import java.util.Optional;
import java.util.UUID;
import javax.annotation.Nonnull;
Expand All @@ -20,7 +19,6 @@
*/
@Slf4j
@UtilityClass
@Beta
public class RequestLogContext {

private static void setCallId(@Nonnull final String callId) {
Expand Down
2 changes: 1 addition & 1 deletion ...-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiBatchInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
*
* @since 1.20.0
*/
@Beta
@JsonSerialize(using = BatchInputSerializer.class)
public class OpenAiBatchInput {
private static final ObjectMapper mapper = getDefaultObjectMapper();
Expand All @@ -38,6 +37,7 @@ public class OpenAiBatchInput {
*
* @param chatCompletionRequests the list of chat completion requests to include in the batch
*/
@Beta
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Question)

What is the rational behind removing the tag on the class level but keeping it on this specific method?

public OpenAiBatchInput(@Nonnull final OpenAiChatCompletionRequest... chatCompletionRequests) {
for (int i = 0; i < chatCompletionRequests.length; i++) {
val request = chatCompletionRequests[i];
Expand Down
2 changes: 0 additions & 2 deletions orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ public CompletionPostResponse executeRequest(@Nonnull final CompletionPostReques
* @return The completion output
* @since 1.15.0
*/
@Beta
@Nonnull
public OrchestrationChatResponse chatCompletionUsingReference(
@Nonnull final OrchestrationConfigReference reference) {
Expand Down Expand Up @@ -298,7 +297,6 @@ public EmbeddingsPostResponse embed(@Nonnull final EmbeddingsPostRequest request
* @return a new client.
* @since 1.11.0
*/
@Beta
@Nonnull
public OrchestrationClient withHeader(@Nonnull final String key, @Nonnull final String value) {
final var newClient = new OrchestrationClient(this.executor);
Expand Down
2 changes: 0 additions & 2 deletions orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationConfigReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.sap.ai.sdk.orchestration;

import com.google.common.annotations.Beta;
import java.util.List;
import java.util.Map;
import javax.annotation.Nonnull;
Expand All @@ -17,7 +16,6 @@
@Value
@AllArgsConstructor(access = AccessLevel.PRIVATE)
@Getter(AccessLevel.PACKAGE)
@Beta
public class OrchestrationConfigReference {
String id;
String scenario;
Expand Down
2 changes: 1 addition & 1 deletion ...tration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationJacksonConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
*
* @since 1.2.0
*/
@Beta
@NoArgsConstructor(access = AccessLevel.NONE)
public class OrchestrationJacksonConfiguration {

Expand All @@ -32,6 +31,7 @@ public class OrchestrationJacksonConfiguration {
* href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.html">Jackson2ObjectMapperBuilder</a>
*/
@Nonnull
@Beta
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Question)

Why do you move the tag here?

public static ObjectMapper getOrchestrationObjectMapper() {

final var module =
Expand Down