chore: Remove @Beta annotations#875
Conversation
| @Beta | ||
| public class OrchestrationConfigClient extends OrchestrationConfigsApi { |
There was a problem hiding this comment.
(minor)
Keep this beta tag since it extends unstable (generated) code
There was a problem hiding this comment.
We said generated code will not be annotated as Beta
There was a problem hiding this comment.
We said generated code will not be annotated as Beta
Yes, but this is not generated code and also for users does not look like generated code. So the instability of the API might not be obvious to users.
| * | ||
| * @param chatCompletionRequests the list of chat completion requests to include in the batch | ||
| */ | ||
| @Beta |
There was a problem hiding this comment.
(Question)
What is the rational behind removing the tag on the class level but keeping it on this specific method?
| * href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.html">Jackson2ObjectMapperBuilder</a> | ||
| */ | ||
| @Nonnull | ||
| @Beta |
There was a problem hiding this comment.
(Question)
Why do you move the tag here?
| @Beta | ||
| public class OrchestrationConfigClient extends OrchestrationConfigsApi { |
There was a problem hiding this comment.
We said generated code will not be annotated as Beta
Yes, but this is not generated code and also for users does not look like generated code. So the instability of the API might not be obvious to users.
3 participants
Context
Remove
@Betaannotations that accumulated over timePrevious PR for context:
@Betatags #761